Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Fix filter card positioning for horizontal native filters #22212

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(dashboard): Fix filter card positioning for horizontal native filters #22212

merged 1 commit into from
Nov 28, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Nov 23, 2022

SUMMARY

This PR is based on #22169 and fixes positioning of filter cards for horizontal and horizontal overflow native filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-11-23 at 3 24 20 PM
Screen Shot 2022-11-23 at 3 24 25 PM

After:
Screen Shot 2022-11-23 at 3 25 32 PM
Screen Shot 2022-11-23 at 3 25 38 PM

TESTING INSTRUCTIONS

  • Confirm that horizontal and horizontal overflow filter cards don't overlap the items they're describing.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml changed the title [WIP] fix(dashboard): Fix filter card positioning for horizontal native filters fix(dashboard): Fix filter card positioning for horizontal native filters Nov 23, 2022
@codyml codyml marked this pull request as draft November 23, 2022 22:27
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #22212 (b960130) into master (64939f2) will not change coverage.
The diff coverage is n/a.

❗ Current head b960130 differs from pull request most recent head 50005b9. Consider uploading reports for the commit 50005b9 to get more accurate results

@@           Coverage Diff           @@
##           master   #22212   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1839     1839           
  Lines       70079    70079           
  Branches     7636     7636           
=======================================
  Hits        46894    46894           
  Misses      21218    21218           
  Partials     1967     1967
Flag Coverage Δ
javascript 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/styles.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje requested review from kgabryje and geido November 24, 2022 18:02
@kgabryje kgabryje marked this pull request as ready for review November 25, 2022 11:09
kgabryje
kgabryje approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 4b96474 into apache:master Nov 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codyml @kgabryje @mistercrunch